test: add unit tests for string path helpers in _plotly_utils.utils#5660
Closed
eeshsaxena wants to merge 1 commit into
Closed
test: add unit tests for string path helpers in _plotly_utils.utils#5660eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_plotly_utils/utils.pyhas a family of small pure string helpers used tobuild the "did you mean" error messages for invalid property paths - splitting
a path, computing character positions, marking them, and suggesting the
closest valid key. Several of them had no direct test coverage.
This adds
tests/test_core/test_utils/test_string_utils.pycovering:split_multichar(split on any of several chars; empty char list is ano-op)
split_string_positions(first-character index of each split piece)display_string_positions(single index,offset/length/char/trimoptions, and the all-indices form) - using the exact examples from the
docstrings
chomp_empty_strings(basic, leading-empty, no-op, the documented specialcases
[]/['']/['','']/['','','',''], andreverse)levenshtein(known distances, zero, empty operand, symmetry)find_closest_string(nearest by edit distance, with lexicographictie-break)
_natural_sort_strings(numeric-aware ordering, andreverse)No source changes.
Verification
pytest tests/test_core/test_utils/test_string_utils.py- 15 passed.ruff check/ruff formatclean.